scala-library-next icon indicating copy to clipboard operation
scala-library-next copied to clipboard

Published 20 hours ago • verified publisher icon scala

Add scalafmt

Open NthPortal opened this issue 4 years ago • 4 comments

NthPortal avatar Nov 04 '20 04:11 NthPortal

could probably use a check in the CI pipeline, but I don't know how

NthPortal avatar Nov 04 '20 10:11 NthPortal

I don't mind having build.sbt be auto-formatted, but I don't see much advantage in it either, and I think it would actually be kind of annoying if PR validation failed just because of a whitespace difference in build.sbt

hmm. were you thinking we should do this in src/main and src/test as well? I see more value there (I'm not actually enthusiastic about it, but not opposed either)

SethTisue avatar Nov 10 '20 03:11 SethTisue

the configuration had better be such that formatting matches the upstream scala repo

the upstream repo is entirely manually formatted, so I don't think that will be an issue

NthPortal avatar Nov 10 '20 04:11 NthPortal

You tagged this as help wanted, I assume with CI checking the fmt? I made a PR for that against this PR.

martijnhoekstra avatar Mar 16 '21 13:03 martijnhoekstra