scala-collection-contrib
scala-collection-contrib copied to clipboard
MultiDict and MultiSet should be either abstract traits or concrete implementations
trafficstars
Currently the pattern between MultiDicts and MultiSets are different:
MultDictis a concrete collectionMultiSetis an abstract data type (trait) with a public concrete implementationMultiSetImpl.
I lean more towards the abstract data type approach of MultiSet, since it is consistent with the rest of the collections. Though the name MultiSetIml/BagImpl isn't very good. Perhaps CountedMultiSet/CountedBag extends MultiSet/Bag?
If the intermediate trait is not needed or useful, I would remove it.