docs.scala-lang icon indicating copy to clipboard operation
docs.scala-lang copied to clipboard

Published 20 hours ago • verified publisher icon scala

modify/correct _zh-cn/index.md

Open benluo opened this issue 3 years ago • 7 comments

modify/correct some translation in _zh-cn/index.md according to latest English version.

benluo avatar May 10 '22 23:05 benluo

@benluo First of all, thank you for your work, it would be better if you could create new pull request. Because big PR isn't easy to be reviewed.

jxnu-liguobin avatar May 17 '22 08:05 jxnu-liguobin

I don't know how to split my pull request. Any way, I will wait to commit my git until you review and merge all translation to main branch.

benluo avatar May 17 '22 11:05 benluo

Hi, @benluo I see the some comments is closed, please resolve it or give a reasonable explanation.

@liufengyun It's almost done, so please take a look.

jxnu-liguobin avatar May 18 '22 03:05 jxnu-liguobin

@jxnu-liguobin I modified translation according to all your comments in my latest commit. So i closed your comments without feedback. Please check my latest commit (300d5cd.

benluo avatar May 18 '22 10:05 benluo

@jxnu-liguobin I modified translation according to all your comments in my latest commit. So i closed your comments without feedback. Please check my latest commit (300d5cd.

sry. It was my misreading.

jxnu-liguobin avatar May 18 '22 12:05 jxnu-liguobin

Any timeline when approved commits will be merged into main/master?

benluo avatar Jun 25 '22 10:06 benluo

Any timeline when approved commits will be merged into main/master?

Any timeline when approved commits will be merged into main/master?

sorry, PR is too large. Because you didn't split it, which will make the review time unpredictable

jxnu-liguobin avatar Jun 25 '22 11:06 jxnu-liguobin

btw, I thought about it, maybe, it is better not to translate sum type?

jxnu-liguobin avatar Aug 25 '22 02:08 jxnu-liguobin

I don't have 《Scala编程第5版》. Do you want to use all terms translation from that book?

benluo avatar Aug 28 '22 03:08 benluo

Hi @SethTisue, Since this PR is really too huge (I'm not looking at it very carefully), do we need to split it into multiple smaller ones? or merge it first and then wait for other volunteers to modify it subsequently.

jxnu-liguobin avatar Sep 02 '22 08:09 jxnu-liguobin

Our usual approach with translations is to merge something even if it isn't perfect, and figure it can always be improved later.

The CI failure needs attention, though?

SethTisue avatar Sep 02 '22 14:09 SethTisue

Our usual approach with translations is to merge something even if it isn't perfect, and figure it can always be improved later.

The CI failure needs attention, though?

corrected.

benluo avatar Sep 02 '22 15:09 benluo

this also looks like https://github.com/scala/docs.scala-lang/pull/2510, which should come first?

bishabosha avatar Sep 13 '22 08:09 bishabosha

this also looks like #2510, which should come first?

Yes, I think this pr should be merged at first.

jxnu-liguobin avatar Sep 13 '22 10:09 jxnu-liguobin

thank you @benluo and @jxnu-liguobin !

SethTisue avatar Sep 13 '22 18:09 SethTisue