sbt icon indicating copy to clipboard operation
sbt copied to clipboard

[2.x] Replace tuple with proper record type for licenses

Open adpi2 opened this issue 1 year ago • 9 comments

This is a merge of https://github.com/sbt/librarymanagement/pull/382, originally by @mdedetrich

@mdedetrich more changes are needed in the the sbt part to make it compile. If you can finish the work, that would be great.

adpi2 avatar Oct 11 '24 14:10 adpi2

Thanks looking into it now

mdedetrich avatar Oct 14 '24 09:10 mdedetrich

@adpi2 I am trying to fix this but I don't have access to your branch to add commits

mdedetrich avatar Oct 18 '24 09:10 mdedetrich

Sorry for that. Could you push to your fork and create another PR then?

adpi2 avatar Oct 18 '24 09:10 adpi2

Sure will do

mdedetrich avatar Oct 18 '24 09:10 mdedetrich

Pull request is here https://github.com/adpi2/sbt/pull/36

mdedetrich avatar Oct 18 '24 10:10 mdedetrich

@adpi2 This should fix the issue with the latest scripted test https://github.com/adpi2/sbt/pull/37

BTW I just noticed now, but is it intended that librarymanagement is going to be inlined into sbt proper rather than sitting as its own module/library?

mdedetrich avatar Oct 18 '24 12:10 mdedetrich

@adpi2 Fix for the latest CI run https://github.com/adpi2/sbt/pull/38

Sorry that this is so iterative, I am currently have issues loading the sbt project properly on my machine right now so relying a bit on CI

mdedetrich avatar Oct 18 '24 13:10 mdedetrich

@adpi2 And again, https://github.com/adpi2/sbt/pull/39. Really hope that this is the last one...

mdedetrich avatar Oct 18 '24 14:10 mdedetrich

@adpi2 Everything passes now!

mdedetrich avatar Oct 21 '24 08:10 mdedetrich

I have another PR here - https://github.com/sbt/sbt/pull/7927

eed3si9n avatar Dec 05 '24 06:12 eed3si9n