sbt-dynver icon indicating copy to clipboard operation
sbt-dynver copied to clipboard

Breaks with SHA longer than 8

Open alexander-bunkenburg-chartboost opened this issue 3 years ago • 1 comments

The "git describe --abbrev=8" returns a SHA with length 8 or more if necessary.

I hit a case where 9 was necessary: "v1.0.20220610+60-97fed8831".

Parsing the SHA in GitDescribeOutput.parse assumes it's exactly 8 characters long.

Encountered today, the issue still happens.

bursauxa avatar Apr 11 '25 12:04 bursauxa

I just encountered this bug in version 5.1.0 and lost 2 hours because of it. I think it’s worth releasing a version where this is already fixed.

dgolda avatar Jun 24 '25 13:06 dgolda

Released https://github.com/sbt/sbt-dynver/releases/tag/v5.1.1

eed3si9n avatar Jun 25 '25 13:06 eed3si9n