librarymanagement icon indicating copy to clipboard operation
librarymanagement copied to clipboard

Cleanup after tests to avoid OOME: Metaspace in fast-run testOnly sequence

Open retronym opened this issue 7 years ago • 4 comments

After these changes, this project no longer exhibits the problems discussed in sbt/sbt#4166.

retronym avatar Jul 13 '18 05:07 retronym

To validate this pull request against other sbt modules, please visit <A HREF="https://jenkins.scala-sbt.org:8592/job/sbt-validator/parambuild/?sbt=1.x&zinc=1.x&io=1.x&librarymanagement=pull/254/head&util=1.x&website=1.x&deploy_to_bintray=false&run_sbt_community=false&verbose_dbuild=false&community_verbose=false">this link.</A>

typesafe-tools avatar Jul 13 '18 05:07 typesafe-tools

I am guessing you mean https://github.com/sbt/sbt/issues/4166. I was using LM test as an example I had handy, but the OP likely had another build exhibiting the issue, so I think we should fix them either in ScalaTest or sbt.

eed3si9n avatar Jul 14 '18 03:07 eed3si9n

Yeah, this is really just a demo of how to do the cleanup in the current version of SBT. The log4j shutdown part is arguably project specific, though I guess SBT could do that in the users behalf by default

On Sat, 14 Jul 2018 at 13:30, eugene yokota [email protected] wrote:

I am guessing you mean sbt/sbt#4166 https://github.com/sbt/sbt/issues/4166. I was using LM test as an example I had handy, but the OP likely had another build exhibiting the issue, so I think we should fix them either in ScalaTest or sbt.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/sbt/librarymanagement/pull/254#issuecomment-404995390, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEAD4VmEU5xBIxkdY_UVnGvgJn9RfYBks5uGWXigaJpZM4VOUWr .

retronym avatar Jul 14 '18 03:07 retronym

I locally still see metaspace climb to 250MB

metaspace2

eed3si9n avatar Jul 16 '18 03:07 eed3si9n