jsonschema-gentypes icon indicating copy to clipboard operation
jsonschema-gentypes copied to clipboard

Sequential instead of random numbers for duplicate names

Open vron opened this issue 6 months ago • 5 comments

Trying to make the generated code reproducible by introducing sequential names instead of randoim ones for dupolicate identifiers. See #1345

vron avatar May 15 '25 19:05 vron

Im stupid, will fix

vron avatar May 16 '25 06:05 vron

Hmmm, not sure this is a problem with my patch? At least I do not see what the problem is

vron avatar May 16 '25 11:05 vron

Here you will see all the changes you should applied: https://github.com/sbrunner/jsonschema-gentypes/pull/1347/checks?check_run_id=42355106898 Or run pre-commit run --all-files :-)

sbrunner avatar May 16 '25 11:05 sbrunner

Ahaa.. Som am i right in understanding that you want em to eg change "if not name in names:" to "if name not in names:" etc. for the patch to be accepted?

vron avatar May 16 '25 11:05 vron

Sill one fix :-)

sbrunner avatar May 16 '25 16:05 sbrunner

Hi again, is there any plan to merge this and include it in a release?

vron avatar Jun 12 '25 11:06 vron

Sorry I forgot it :-)

sbrunner avatar Jun 12 '25 14:06 sbrunner

Released in 2.12.0

sbrunner avatar Jun 12 '25 14:06 sbrunner