sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

SBPP Sleuth plugin is using old library name on versions 1.6.3 an above

Open GAMMACASE opened this issue 3 years ago • 2 comments

What are the steps to reproduce this issue?

Using either 1.6.3 or 1.6.4 plugin packages from the release tab would provide same result of sbpp-sleuth not doing anything.

What happens?

sbpp-sleuth plugin is looking for a library named sourcebans https://github.com/sbpp/sourcebans-pp/blob/8760d6e333c76e34cc0e104e7ace229f05bed133/game/addons/sourcemod/scripting/sbpp_sleuth.sp#L91-L110 but in versions 1.6.3 and above library name that was registered in sbpp-main was changed to sourcebans++ https://github.com/sbpp/sourcebans-pp/blob/8760d6e333c76e34cc0e104e7ace229f05bed133/game/addons/sourcemod/scripting/sbpp_main.sp#L141

In the end sbpp-sleuth would result in awaiting for the dependency and won't do anything, since there are checks that expects library to be loaded. https://github.com/sbpp/sourcebans-pp/blob/8760d6e333c76e34cc0e104e7ace229f05bed133/game/addons/sourcemod/scripting/sbpp_sleuth.sp#L142

Any other comments?

Since it's not a problem on latest 1.7.0+ versions as it was updated there, not sure if you still want to provide plugin packages that don't work out of the box and need manual tweaking/downgrading/fixing etc.

GAMMACASE avatar Aug 02 '22 13:08 GAMMACASE

@Hackmastr is this something we want to loop in with your updates to support PHP 8.1?

ashort96 avatar Aug 25 '22 21:08 ashort96

@Hackmastr is this something we want to loop in with your updates to support PHP 8.1?

No, since the PHP81 branch is based on the master branch. Thanks.

Hackmastr avatar Aug 26 '22 22:08 Hackmastr