Saurabh Nanda

Results 351 comments of Saurabh Nanda

At a conceptual level, the pattern/architecture that you seem to be going towards is the following: transform the HTTP request (incoming JSON, query parameters, incoming patch/diff, etc), to functions/data-structures that...

> Only ProductFilter is defined using a persistent specific interface. I'm sure if you think hard enough you'll be able to state type-safe updates in terms of a Persistent interface,...

> Neither ProductView nor ProductComparator are getting used right now. What would it do to the Servant API signatures, if you use ProductView completely?

So, is this sprint complete? > Adding activation for user/tenant creation Tenant creation code still has some `undefined`, right? Also, storing the activation key in the DB? > Implement Product...

> Yes, but by explicitly stating that it is a Monoid, we get to use a nice interface(mconcat) which behaves in a mathematically consistent way, making it easier to reason...

Thanks for the quick primer on Monoids. Any comments on: > Also, do you want to add anything to this PR?

Comments: - Is there any way to run custom SQL statements in-sync with the Persistent migration? For example, if I want to add a custom `CHECK CONSTRAINT` on a table,...

I'm missing something in the updation infrastructure again. Why is the following erroring out? What exactly does one need to pass to an `Updater '[x]`? ``` :t (dbUpdateUser (toSqlKey 10)...

Also, just thinking aloud, if we have the `Updater x` infra working properly, do we really need the `*Input` pattern (eg. `UserInput`, `TenantInput`, etc)? Can't we apply the same principles...