sas-studio-custom-steps icon indicating copy to clipboard operation
sas-studio-custom-steps copied to clipboard

improve the readability of the about section and increase length of internal directory variable to handle very deep directories (from 1024 to 4096), also adding k functions where appropriate

Open stephanweigandt opened this issue 1 year ago • 1 comments
trafficstars

Please include answers to these questions as part of your pull request

In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

  • Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).
    • [X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
    • [ ] No
  • Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.
    • [X] My contribution does NOT include PII data
    • [ ] My contribution includes PII data
  • Q3: Confirm your contribution does not include any encryption or other export-controlled technology.
    • [X] My contribution does NOT contain encryption or other export-controlled technology
    • [ ] My contribution includes encryption or other export-controlled technology ContributorAgreement.txt

stephanweigandt avatar Sep 26 '24 23:09 stephanweigandt

This pull request addresses issue #165 and a bit more.

stephanweigandt avatar Sep 26 '24 23:09 stephanweigandt

Hi Stephan (@stephanweigandt),

Thanks for providing this fix and also using k functions for string manipulations to things work properly when strings contain contain multi-byte encoded characters.

Will merge it as-is, but wanted to create some awareness of the best practice of removing all SAS macros and SAS macro variables that you as a step author created yourself in the codegen. Btw. this is part of _template.step.

/***
  Delete user-defined SAS macros and SAS macro variables using nowarn option.
  Using nowarn to prevent warning messages in SAS log in case the item does not exist because
  it is only created conditionally depending on user selections. A valid use case. 
  Using nowarn avoids the need for the step author to add additional logic that first checks whether
  the item exists before trying to delete it.
***/
%symdel mymacrovar1 / nowarn;
%symdel mymacrovar2 / nowarn;
...
%sysmacdelete mymacro1 / nowarn;
%sysmacdelete mymacro2 / nowarn;

snlwih avatar Oct 09 '24 13:10 snlwih

SAS Internal Due Diligence Review - COMPLETED on 09OCT2024

snlwih avatar Oct 09 '24 13:10 snlwih