libsass-python icon indicating copy to clipboard operation
libsass-python copied to clipboard

Published 20 hours ago • verified publisher icon sass

Add support for musl wheels

Open ObserverOfTime opened this issue 3 years ago • 7 comments

This closes #391. I've tested the musl wheel on Alpine edge and it works.

It might be worth creating a new release if and when this PR is merged. Both this change and the Python 2 removal (d333e3c419f48f4b2d96528cb4c83db1f02adaec) are quite important.

ObserverOfTime avatar Aug 14 '22 08:08 ObserverOfTime

please don't touch unrelated files

asottile avatar Aug 14 '22 11:08 asottile

OK, I'll let you fix those yourself.

ObserverOfTime avatar Aug 14 '22 12:08 ObserverOfTime

is this image official? I can't find any docs for it

asottile avatar Aug 15 '22 00:08 asottile

It's official. It was added in pypa/manylinux#1135.

ObserverOfTime avatar Aug 15 '22 07:08 ObserverOfTime

it's undocumented so I would prefer to wait until the linked issue there is resolved before depending on undocumented behavior

asottile avatar Aug 15 '22 12:08 asottile

So, it's fine to depend on a deprecated image (manylinux1) but not an undocumented one?

ObserverOfTime avatar Aug 15 '22 12:08 ObserverOfTime

The "undocumented" image is already used by pypa/cibuildwheel. There's really no reason not to depend on it.

ObserverOfTime avatar Aug 19 '22 11:08 ObserverOfTime

Would you accept a pull request that builds the wheels with cibuildwheel on GitHub actions instead?

ObserverOfTime avatar Jan 18 '23 17:01 ObserverOfTime

I'll take that as a no.

ObserverOfTime avatar Mar 20 '23 09:03 ObserverOfTime