sass-embedded error with bootstrap 5.3.3

[arnriu]

Since bootstrap 5.3.3, sass-embedded throw an error. The problem was not present with bootstrap 5.3.2 and earlier, and is not present with normal sass package.

Here is the link to the open issue in bootstrap repo, with a reduced test case in a reproducible environment: https://github.com/twbs/bootstrap/issues/39978#issue-2292514748

More specifically, the problem seems to be this line. If we remove it, everything runs fine: https://github.com/twbs/bootstrap/blob/d2d4581790da2618d3fe063dafaa6205c73aabdd/scss/_variables.scss#L1751

[ntkme]

I tested locally with a standalone setup without vite, both new API and legacy API worked just fine. This seems to be issue only when compiling via vite as pointed out by this comment: https://github.com/twbs/bootstrap/issues/39978#issuecomment-2173495103

sass-embedded's emulated legacy API is indeed not fully compatible with sass in some corner cases. We can potentially look into what's the difference and try to fix it. However, at this point it would be much better for vite team to switch to the new API instead: https://github.com/vitejs/vite/issues/7116

[nex3]

Can you provide a minimal reproduction of this that doesn't involve a bunch of external dependencies?

[arnriu]

Sure. Here it is without react, only vite + sass-embedded + bootstrap.

As a reminder:

• in src/index.sass if you comment out @import bootstrap/scss/variables it will work. But if you let it, it will throw an error.
• And in this file from the bootstrap package, variables it is the last line @import causing the problem. I didn't dig more.
• if you switch from "sass": "npm:[email protected]", to "sass": "npm:1.77.1", in package.json , run npm install and try again, it will work well as well. Problem only exists with sass-embedded.

https://codesandbox.io/p/devbox/competent-mahavira-forked-3jh7fj?file=%2Fpackage.json

[nex3]

I'm looking for a reproduction without vite as well—for all we know, this is a bug in Vite's custom importer.

[Digital-Pig-LLC]

Was this resolved, or just closed? I'm running the latest version of this and trying to compile Bootstrap v5.3.2 and v5.3.3 I get the same 30 issues.

Unresolvable

Cannot resolve '--bs-body-text-align' custom property Unknown pseudo selector '-webkit-datetime-edit' Cannot resolve '--bs-dropdown-item-border-radius' custom property Cannot resolve '--bs-nav-link-font-size' custom property Cannot resolve '--bs-scroll-height' custom property Cannot resolve '--bs-breadcrumb-font-size' custom property Cannot resolve '--bs-breadcrumb-divider' custom property Cannot resolve '--bs-focus-ring-x' custom property Mismatched parameters ( [, {2,4}]?) Cannot resolve '--bs-focus-ring-y' custom property Mismatched parameters ( [, {2,4}]?) Cannot resolve '--bs-focus-ring-blur' custom property Mismatched parameters ( [, {2,4}]?) Cannot resolve '--bs-icon-link-transform' custom property

Missing values

--bs-btn-font-family: ; --bs-dropdown-box-shadow: ; --bs-nav-link-font-weight: ; --bs-nav-link-font-weight: ; --bs-card-title-color: ; --bs-card-subtitle-color: ; --bs-card-box-shadow: ; --bs-card-cap-color: ; --bs-card-height: ; --bs-card-color: ; --bs-breadcrumb-bg: ; --bs-breadcrumb-border-radius: ; --bs-toast-color: ; --bs-modal-color: ; --bs-modal-footer-bg: ; --bs-tooltip-margin: ;

[Digital-Pig-LLC]

Info ########## [email protected] | MIT | deps: 6 | versions: 61 Node.js library that communicates with Embedded Dart Sass using the Embedded Sass protocol https://github.com/sass/embedded-host-node#readme

dist .tarball: https://registry.npmjs.org/sass-embedded/-/sass-embedded-1.77.8.tgz .shasum: d8d885ccd59c6040fcccd345299a115187d65726 .integrity: sha512-WGXA6jcaoBo5Uhw0HX/s6z/sl3zyYQ7ZOnLOJzqwpctFcFmU4L07zn51e2VSkXXFpQZFAdMZNqOGz/7h/fvcRA== .unpackedSize: 744.2 kB

dependencies: @bufbuild/protobuf: ^1.0.0 immutable: ^4.0.0 supports-color: ^8.1.1 buffer-builder: ^0.2.0 rxjs: ^7.4.0 varint: ^6.0.0

maintainers:

• nex3 [email protected]
• sassbot [email protected]

dist-tags: latest: 1.77.8

[nex3]

@Digital-Pig-LLC none of those errors are coming from Sass.

[Digital-Pig-LLC]

No, they appear in the compiled CSS which is compiled from bootstraps SCSS files using [email protected]. What I did notice is that for all of the missing values there is a null value assigned in the bootstrap SCSS file. For example, in the SCSS there will be: --bs-btn-font-family: null !default; and that will result in an empty value upon compilation.

I ran the request as follows so ensure it wasn't my PHPStorm that was causing the issue: .\node_modules\sass-embedded-win32-x64\dart-sass\sass.bat ......\PhpstormProjects\vTribes\2.0-php82\src\vg_config\scss\cpnl.scss ......\PhpstormProjects\vTribes\2.0-php82\src\public_html\css\cpnl.css

My cpnl.scss has an import from root.scss, which is where the imports for bootstrap exist.

A very simple case of root.scss: :root { --app-width: 1000px; --app-cp-width: 1200px; --app-bg-light: #909dba; --app-bg-dark: #7b849a; --app-accent: #1c3744; }

@import "../../node_modules/bootstrap/scss/bootstrap";

and in my cpnl.scss: @import "root";

The resulting CSS file ends up with 30 errors, as shown above, regardless of using bootstrap v5.3.2 or 5.3.3 as source.

[nex3]

I'm not sure what you mean by an error "appearing in" compiled CSS. CSS itself doesn't produce any errors—only tools that consume it.

If you have a specific case where Embedded Sass is producing the wrong output, especially if you can produce a minimal reproduction of that case, I can look into it. But this doesn't really give me any information about what Sass is doing or what behavior you expect.

[Digital-Pig-LLC]

Ok, maybe I'm not using correct terminology or maybe we're just not understanding each other. I have the source SCSS files from Bootstrap. When I try to compile them using sass-embedded, the output CSS files are missing values, making them invalid. When looking at the missing values in _variables.scss I see that they are marked as: null !default

Surely if this were a global problem with all compilers, there would be a lot of invalid CSS and Bootstrap would make us aware...how did we even get to 5.3.3 as stable if this were the case.

Uncompiled -> sass-embedded -> compiled...is that not the workflow?

Please correct me if I'm wrong in any of this. I'm certainly no SCSS wizard

[nex3]

What is the CSS output you expect, the CSS output you're actually getting, and the Sass that produces it?

[julien-deramond]

For embedded-host-node maintainers, I hope I don't overstep, feel free to hide this message if it generates noise :)

---

Hey @Digital-Pig-LLC, one of the Bootstrap maintainers here. Based on what I can see in your https://github.com/sass/embedded-host-node/issues/305#issuecomment-2322183268 message, the warnings/errors are related to https://github.com/twbs/bootstrap/issues/36595, https://github.com/twbs/bootstrap/issues/38474, and many other duplicates in our Bootstrap repository. These warnings/errors are not related to Sass, and are not related to this embedded-host-node issue. They are related to Bootstrap, and are not really issues but development choices, even if we'll try to improve the situation by dropping some of them from the generated CSS file.

[nex3]

I'm going to close this out since the original reporter has not provided further information for over a month.