git-journal icon indicating copy to clipboard operation
git-journal copied to clipboard

Fixed issue where tags at the beginning of summary not parsed correctly.

Open jwir3 opened this issue 4 years ago • 2 comments

If tags appeared before the category when parsing, the tags would not be added to the list of tags in the commit message. This was due, in part, to a regular expression that did not consider the possibility that the tag could be at the beginning of a line, and partially due to the fact that tags were only parsed from the remainder of the line AFTER categories had been removed.

Fixes #928.

jwir3 avatar Jun 26 '21 21:06 jwir3

@saschagrunert I think perhaps I added the third test repository incorrectly. I'm not super familiar with git submodules. Could you advise on how I should add the necessary data to test this particular case?

jwir3 avatar Jun 26 '21 21:06 jwir3

@saschagrunert I think perhaps I added the third test repository incorrectly. I'm not super familiar with git submodules. Could you advise on how I should add the necessary data to test this particular case?

Hm, we could also add the whole test repository to the tests directory without using submodules. :thinking:

saschagrunert avatar Jun 28 '21 06:06 saschagrunert