phpstan-typo3

phpstan-typo3 copied to clipboard

Having a class called …Repository should not mandate it being an Extbase repository

8

The repository pattern existed before Extbase and is useful w/o Extbase, so having a check that lets PhpStan fail if a class called `SomethingRepository` does not (directly or via a...

andreaswolf

Possible improvement of the default requestGetAttributeMapping for "site"

3

Hi, I just noticed, that `$request->getAttribute('site')` is by default configured to return a Site object. The attribute could, however, also hold an instance of `NullSite`, so I reconfigured the `requestGetAttributeMapping`...

ervaude

Add findBy method to Repository.stub

2

Since TYPO3 the magic find by methods are deprecated. https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.3/Deprecation-100071-MagicRepositoryFindByMethods.html We are still loading our custom Repository.stub, so we should include this method in the stub as well.

sabbelasichon

oliverklee

Added 2 new request attribute mappings for TYPO3 v13

3

* Added `frontend.page.information` - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendPageInformation.html#frontend-page-information * Added `frontend.cache.instruction` - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendCacheInstruction.html#frontend-cache-instruction

derhansen

I am getting an error when creating a custom repository with a createQuery method: ``` Return type (TYPO3\CMS\Extbase\Persistence\QueryInterface) of method Example\Example\Domain\Repository\NewsRepository::createQuery() should be compatible with return type (TYPO3\CMS\Extbase\Persistence\QueryInterface) of method...

rvock

The execute method has a boolean argument that defines if a raw result should be returned. This means that no object mapping is done but an array containing the result...

sascha-egerer

Go through all stubs: - check which annotations already are in the Core and delete them here - if not, add them to the Core - if necessary, add backports...

oliverklee

Due to the previous need to be compatible with the PHPStan releases, our release versions were always aligned with the release versions of PHPStan. However, since this is no longer...

sascha-egerer

The request attribute `frontend.cache.collector` is currently mapped on the class `TYPO3\CMS\Frontend\Cache\CacheCollector`, which does not exist. The correct class is `TYPO3\CMS\Core\Cache\CacheDataCollector`

tillhoerner