saros icon indicating copy to clipboard operation
saros copied to clipboard

Check for unused libraries

Open tobous opened this issue 5 years ago • 3 comments
trafficstars

As far as I can tell, different Saros components currently contain a number of outdated libraries. Such libraries should be removed from the corresponding projects.

Examples of such libraries are jmdns or xpp3, which are imported into the core but never used as far as I can tell.

To resolve this, we should have a look at which libraries we currently import and which are actually necessary.

tobous avatar Feb 25 '20 17:02 tobous

I think xpp3 is used in saros.net.internal.XMPPReceiver (import org.xmlpull.* imports).

m273d15 avatar Feb 26 '20 12:02 m273d15

But we have two different versions of xpp3. We have xpp3 and xpp3_min. xpp3 is declared in our build file and xpp3_min is included as a transitive dependency. So the declaration of xpp3 might still not be necessary.

tobous avatar Feb 26 '20 12:02 tobous

Also, it still builds, tests, and runs correctly (at least for Saros/I) if I remove the explicit xpp3 dependency from the core build.gradle file.

tobous avatar Feb 26 '20 12:02 tobous