saros icon indicating copy to clipboard operation
saros copied to clipboard

Replace `compile*` configurations in gradle build files

Open m273d15 opened this issue 6 years ago • 3 comments

The gradle java plugin marked the dependency handling via compile and testCompile as deprecated. We should use implementation, testImplementation, api (which is new) and provided (instead of compileOnly). See here for more information

m273d15 avatar Jan 29 '19 11:01 m273d15

This issue has to be fixed before updating to Gradle 7 in the future. This is already mentioned by the gradle 6 build:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.1/userguide/command_line_interface.html#sec:command_line_warnings

m273d15 avatar Jan 21 '20 13:01 m273d15

Also, IntelliJ complains about the usage of some deprecated fields and some closure stuff in multiple of the build.gradle files. It isn't that important (and I think some of it was already present before the update to Gradle 6), but you could still have a look at it if you are in the process of cleaning up anyways.

tobous avatar Jan 21 '20 13:01 tobous

I started to fix all these issues but recognized that this goes beyond updating gradle. I think the tasks to fix this are:

  • replace all usages of version with archiveVersion
  • replace all usages of xyCompile with xyImplementation (which could break some logic and has to be tested with stf)

m273d15 avatar Jan 21 '20 13:01 m273d15