saros icon indicating copy to clipboard operation
saros copied to clipboard

[INTERNAL][CORE] Redo optimization to Socks5 transport

Open srossbach opened this issue 5 years ago • 1 comments

The current code was hard to understand and not really maintainable.

Removed the simultaneous connection attempts in both directions. Only one connection attempt is made as is it very likely the the reverse connection attempt will also fail if the first one fails.

The logic could be reintroduced but we should ensure that the connection attempt to B->A is made after A->B and not in parallel to keep the logic simple.

srossbach avatar Jul 31 '20 00:07 srossbach

Codacy Here is an overview of what got changed by this pull request:


Complexity decreasing per file
==============================
+ core/src/saros/net/stream/Socks5StreamService.java  -4
         

See the complete overview on Codacy

saros-infrastructure avatar Jul 31 '20 00:07 saros-infrastructure