framework
framework copied to clipboard
feat: add interaction support to args
Super rough PR to take a first stab at adding interaction support to Args. Wanted to get some feedback before going any further since I don't know if I'm going in the right direction with this implementation. Basically, Args stays the same but either wraps lexure or a ChatInputParser.
The biggest problem with the current implementation is that .many doesn't map very well to slash commands. Would love any suggestions.
Resolves #494
@vladfrangu please review this PR (as discussed in DMs)
@vladfrangu Tried to make args abstract based on that document. I had to fight typescript to get peek to work, but I'm not sure how to do it better.
Also I cannot express enough with words that I am hella grateful that you're taking on this (quite challenging) issue! Don't let the barrage of requested changes scare you! ❤️
Thanks for the kind words! Most of this was just moving stuff to the base class, so it was pretty easy changes. Appreciate that you're taking time to look over it.
@sapphiredev pack this
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 68d8c87. You can monitor the build here!
Packed under @sapphire/[email protected]
Also, should I be marking conversations as resolved or do you wish to do that?
Also, should I be marking conversations as resolved or do you wish to do that?
Feel free to mark any resolved convo as resolved
@sapphiredev pack this
Heya @vladfrangu, I've started to run the deployment workflow on this PR at d435f5c. You can monitor the build here!
@sapphiredev pack
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 524e708. You can monitor the build here!
@vladfrangu Any updates about this? I'm still not sure if my implementation of many() makes sense.