framework icon indicating copy to clipboard operation
framework copied to clipboard

feat: add interaction support to args

Open samfundev opened this issue 1 year ago • 16 comments

Super rough PR to take a first stab at adding interaction support to Args. Wanted to get some feedback before going any further since I don't know if I'm going in the right direction with this implementation. Basically, Args stays the same but either wraps lexure or a ChatInputParser.

The biggest problem with the current implementation is that .many doesn't map very well to slash commands. Would love any suggestions.

Resolves #494

samfundev avatar Feb 17 '24 21:02 samfundev

@vladfrangu please review this PR (as discussed in DMs)

favna avatar Feb 28 '24 18:02 favna

@vladfrangu Tried to make args abstract based on that document. I had to fight typescript to get peek to work, but I'm not sure how to do it better.

samfundev avatar Mar 02 '24 15:03 samfundev

Also I cannot express enough with words that I am hella grateful that you're taking on this (quite challenging) issue! Don't let the barrage of requested changes scare you! ❤️

vladfrangu avatar Mar 02 '24 15:03 vladfrangu

Thanks for the kind words! Most of this was just moving stuff to the base class, so it was pretty easy changes. Appreciate that you're taking time to look over it.

samfundev avatar Mar 02 '24 17:03 samfundev

@sapphiredev pack this

vladfrangu avatar Mar 12 '24 17:03 vladfrangu

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 68d8c87. You can monitor the build here!

sapphiredev[bot] avatar Mar 12 '24 17:03 sapphiredev[bot]

Packed under @sapphire/[email protected]

vladfrangu avatar Mar 12 '24 18:03 vladfrangu

Also, should I be marking conversations as resolved or do you wish to do that?

samfundev avatar Mar 14 '24 15:03 samfundev

Also, should I be marking conversations as resolved or do you wish to do that?

Feel free to mark any resolved convo as resolved

vladfrangu avatar Mar 14 '24 17:03 vladfrangu

@sapphiredev pack this

vladfrangu avatar Mar 14 '24 17:03 vladfrangu

Heya @vladfrangu, I've started to run the deployment workflow on this PR at d435f5c. You can monitor the build here!

sapphiredev[bot] avatar Mar 14 '24 17:03 sapphiredev[bot]

@sapphiredev pack

vladfrangu avatar Mar 17 '24 12:03 vladfrangu

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 524e708. You can monitor the build here!

sapphiredev[bot] avatar Mar 17 '24 12:03 sapphiredev[bot]

@vladfrangu Any updates about this? I'm still not sure if my implementation of many() makes sense.

samfundev avatar Apr 10 '24 16:04 samfundev