framework icon indicating copy to clipboard operation
framework copied to clipboard

request: update `Args` to support Chat Input commands

Open favna opened this issue 3 years ago • 1 comments

Is there an existing issue or pull request for this?

  • [X] I have searched the existing issues and pull requests

Feature description

When we first wrote Sapphire we added support for Arguments for message-based commands, however, they were never updated for Chat Input commands in version 3 as we had to cut it in order to be able to ship v3 sooner. That means it is moved to the scope of v4 and this issue is to track this feature.

Desired solution

Arguments has to be updated to support Chat Input commands

Alternatives considered

  • Only using the resolvers for Chat Input commands. As resolvers already make the backbone of Arguments and Chat Input command arguments are only really relevant for String type Chat Input commands the string content could easily be parsed by resolvers.
    • This is a valid argument, however supporting Arguments will allow more syntactic sugar and allow for less code to achieve the same.,

Additional context

No response

favna avatar Jul 24 '22 15:07 favna

Copying the following blurb from #646

@vladfrangu has added to this topic:

bc I want to make args have a consistent interface between types Basically make Args an interface now and then MessageArgs/ChatInputCommandArgs implement it and then people can just use it without thinking of what they are using it in also it's hella breaking LOL sapphire v5 lets GOO

favna avatar Feb 17 '24 22:02 favna