lemonaid icon indicating copy to clipboard operation
lemonaid copied to clipboard

URL should also support addressing by SAP Mentor Number

Open gregorwolf opened this issue 8 years ago • 4 comments
trafficstars

The URL created when you navigate to the details is:

https://finder.sapmentors.sap.com/#/Mentor/9694b425-16c9-41e6-8b6e-9face8148c52

Perhaps we find a way to make it work also with the SAP Mentor Number https://finder.sapmentors.sap.com/#/Mentor/2

gregorwolf avatar Feb 21 '17 13:02 gregorwolf

The mentor number is unfortunately ambiguous and cannot be used as a key.

jpenninkhof avatar Feb 21 '17 14:02 jpenninkhof

I had an early commit that had it like this at the beginning but as Jan mentioned, the mentor numbers are re-used.

Would it be possible to make the URL router smart enough to map the pattern to where mentor number = 123 and status = active perhaps?

entmike avatar Feb 21 '17 14:02 entmike

The first commits indeed used the mentor number as primary key. However, difficulties arose with new mentors that didn't have a number yet, alumni and project team members such as Jonas. Because we had to build in too many we just couldn't use this as the primary key.

We could however see if we can build a redirector sometime. To have the Mentor/byNumer/2 to redirect to /Mentor/{guid} or something. Would that help?

jpenninkhof avatar Feb 21 '17 14:02 jpenninkhof

Probably many valid alternatives like that.

/Mentor/{guid} /Number/{number} -> /Mentor/{guid}

I suppose you could even technically have a First and Last name URL that would be pretty unique but could also redirect. It could make for a more memory-friendly option.

/Name/{Firstname_Lastname} -> /Mentor/{guid}

entmike avatar Feb 21 '17 15:02 entmike