Santhosh

Results 19 comments of Santhosh
trafficstars

> Maybe @santacodes you can try out with a draft PR (or in a branch on your fork) and we can see to it if everything works well in CI?...

> I think #3879 is going to take a bit of time for now, so we can close this issue at least (since ODES has been removed in #3932). Could...

Working on a PR, with some changes in dockerfile, docker workflow and docs. Hopefully will open it by tomorrow.

> Hey, @santacodes! I wanted to ask if you could finish the pull request. I need to make some changes to the Dockerfile to adjust the build commands, but since...

@arjxn-py do you mind if I change the standard `pip` installations of packages to `uv`? Could it possibly reduce the build times?

Also while running unit tests inside the docker container it prompted this - ```bash SKIPPED [1] tests/unit/test_solvers/test_idaklu_jax.py:91: Both IDAKLU and JAX are available SKIPPED [1] tests/unit/test_util.py:91: The JAX solver is...

> Yes currently it skips if `pybamm.have_jax()`, which should not happen. I should have been a mistake while #4214, see [here](https://github.com/pybamm-team/PyBaMM/pull/4214/files#diff-213a36200d41e6897aaba82ed856a037dcf622587acf920011b95c64d3428338R76-R78) Feel free to modify this, there should not be...

> @santacodes Just an FYI, force pushing removes the history of what was reviewed. Try not to force push after review has started Sorry my commits got messed up between...

> If it's out of scope for ruff, does anyone know of a tool that might accomplish this? I think you should check out [lychee](https://github.com/lycheeverse/lychee). It can integrate with CI...