sandstrom

Results 542 comments of sandstrom
trafficstars

:clap: Great! A few points (you have probably already thought of them): - It's important to specify the VAT sum instead of VAT rate, since a single purchase may include...

Feel free to disagree here, but would a relative tax percentage really be needed? A `vatAmount` is enough to back out the vat percentage if needed[1]. If the total price...

@danbri @vholland what's the state on this? This would be an awesome enhancement! ⛵️

@RichardWallis Yes, that would do it. Also, `valueAddedTaxIncluded` should be deprecated (the presence of `valueAddedTaxAmount` will itself signify the same thing as the boolean). *** *While I think `valueAddedTaxAmount` works...

@MikeRalphson @webron @darrelmiller happy to hear your thoughts! Maybe I've missed something obvious, that makes this a bad idea.

@erunion @mjcuva Sorry for the direct ping, but this (this issue and the linked PR https://github.com/OAI/OpenAPI-Specification/pull/4288) should help fix an annoyance in your API. Before this fix we need to...