vagrant-spk icon indicating copy to clipboard operation
vagrant-spk copied to clipboard

lemp & lesp stack: Remove php.ini limit on POST & file upload size

Open paulproteus opened this issue 9 years ago • 3 comments

See discussion starting at: https://botbot.me/freenode/sandstorm/2016-04-20/?msg=64536140&page=1

Other notes:

  • I personally believe we should move php.ini into service-config/; @zarvox do you agree?
  • We need to adjust post_max_size and upload_max_filesize to both be 0, seemingly.

paulproteus avatar Apr 20 '16 04:04 paulproteus

Once we've done that, we might want to request that @jparyani bump the MediaWiki app to use these changes, so that the issue report in the original submission is truly fixed.

paulproteus avatar Apr 20 '16 04:04 paulproteus

+0 on moving php.ini into service-config. The caveat is that there are a variety of php modules that ship config snippets so their native-code modules (typically pulled from apt, but sometimes compiled locally) will get loaded.

App authors would have to reproduce these snippets in the service-config folder, or we'd have to do some semi-gross thing where we symlink from /opt/app/.sandstorm/service-config/php/conf.d to the folder from /etc/ where these snippets are typically linked in for php5-fpm, or something. Then it's arguably more confusing for app authors to track down what's going on.

But maybe that's still better than sed-ing config files in place with inscrutable regexes.

zarvox avatar Apr 20 '16 23:04 zarvox

It could be that we have a php.ini overrides that we create, and we modify the global one to include ours as well as the system one. Hmm.​

paulproteus avatar Apr 21 '16 00:04 paulproteus