omega_h icon indicating copy to clipboard operation
omega_h copied to clipboard

New assert occurs with v9.34 when instantiating an Omega_h::Library

Open tristan0x opened this issue 4 years ago • 1 comments

I am surprised to notice this change that now expects argc and argv to not be nullptr: https://github.com/sandialabs/omega_h/blob/140c95189b89ef33d03dcd07a8da2de2336acd29/src/Omega_h_library.cpp#L70-L74

... since Library provides a default constructor:

https://github.com/sandialabs/omega_h/blob/140c95189b89ef33d03dcd07a8da2de2336acd29/src/Omega_h_library.hpp#L13

Blue Brain Project doesn't mind updating its usage to now passes argc and argv, but maybe introduce 2 breaking changes in Library API:

  1. remove the Library default constructor
  2. expect argc and argv to be rvalue, not pointers.

tristan0x avatar Oct 20 '21 07:10 tristan0x

@tristan0x my bad, it looks like I allowed in some changes that I shouldn't have. I will remove those asserts in a bit.

ibaned avatar May 02 '22 20:05 ibaned