Universal-LPC-Spritesheet-Character-Generator icon indicating copy to clipboard operation
Universal-LPC-Spritesheet-Character-Generator copied to clipboard

Fix Missing OGA-BY Licenses

Open jrconway3 opened this issue 1 year ago • 2 comments

So after discussing things over with MedicineStorm I figured out that a lot of licenses here are outdated.

The following assets actually have added the OGA-BY license:

  1. All LPC Assets Created by Sharm
  2. All LPC Assets Created by Redshrike (these DO appear to be correct already)
  3. All LPC Assets Created by Makrohn (golden armor does not qualify due to derivative assets)
  4. MadMarcel's Orcs and Pirates
  5. Many of such assets I also made derivatives of, allowing this entire thing to be updated fully to OGA-BY as well: https://opengameart.org/content/lpc-curly-hair-elven-ears-white-cape-with-blue-trim-and-more
  6. These early hairstyles: https://opengameart.org/content/ponytail-and-plain-hairstyles
  7. At least some of Wulax's LPC assets: https://opengameart.org/content/lpc-medieval-fantasy-character-sprites
  8. According to MedicineStorm all of Wulax's LPC assets are in OGA-BY
  9. Same as Nilla122's LPC assets: https://opengameart.org/content/lpc-lizard-headgear

This is the stuff I have confirmed so far. I'll work on applying these licenses to the CREDITS.csv.

MadMarcel actually fully replaced the CC-BY-SA license with OGA-BY, however, because it was originally released under CC-BY-SA I'll keep both licenses here.

I just noticed this dilemma because I had not double-checked my licenses when MedicineStorm asked me to update that listed, and I noticed in here many of the assets I was derivative of are still listed under CC-BY-SA only, even though they are available in OGA-BY as well. I'll work on confirming which assets were confirmed to be OGA-BY and update those licenses only.

jrconway3 avatar Apr 30 '24 18:04 jrconway3

I left this comment on that issue above, but I'd rather keep it here.

So I fixed many OGA-BY licenses by following up with MedicineStorm and reviewing the list above. I went through line-by-line and checked the original entries, many of which have in fact been updated to OGA-BY.

Some I had to question whether to add them or not. For example, bluecarrot16 often posts big lists of re-releases and I'm not sure how modified these assets are in there. If bluecarrot16 mentioned that the asset was heavily modified, I opted not to update the license. If bluecarrot isn't credited at all, even if one of these lists was included, I decided to include the OGA-BY for sure. Other instances were hit or miss, so I was trying to be cautious about whether including it or not.

As far as I can tell, Manuel Riecke did most of the original haistyles except Princess (done by Sharm). Manuel Riecke has not been confirmed to have approved OGA-BY 3.0 to my knowledge, so I didn't include any of his assets. Sharm, Redshrike, Wulax, Mad Marcel, Nilla122, Makrohn, and Joe White have a good chunk of updates in here, though, and as such, this added a lot of OGA-BY licenses.

I also fixed the attribution on "parted" hairstyle; this was Manuel Riecke and I simply cleaned up two of the "down" animation poses.

Please let me know if I made any mistakes by adding an OGA-BY license where it should not have gone, but I tried to be very careful with this one.

Even though the above PR was merged I noticed this issue was not closed. Probably a good idea so we can still have others double-check and confirm the licenses updates are accurate and perhaps add any more, too.

jrconway3 avatar May 01 '24 14:05 jrconway3

I'll gradually start listing new entries I find that are fringe cases, such as Nilla122's braided hair: hair/braid/female/blonde.png: by Nila122, ElizaWy. License(s): CC-BY-SA 3.0, GPL 3.0, GPL 2.0 https://opengameart.org/content/3-hairs-for-lpc

While this is primarily credited to Nilla122 and ElizaWy it was re-released and modified by bluecarrot16. I feel like this is a case where it can be updated to OGA-BY even though OGA-BY is not listed on bluecarrot16's entry: https://opengameart.org/content/lpc-hair

If any more fringe cases like this are seen that weren't updated, we can list them here and they can gradually get updated.

jrconway3 avatar May 01 '24 18:05 jrconway3

Updated this to include Waistband and center_long_part which are missing credits from licensing-handling, as well as the licenses from #228. If we find other assets that have missing or broken licenses they should be noted here.

If they're not fixed, the reason is because we're still unsure at this point exactly what licenses should be handled.

jrconway3 avatar Jan 02 '25 19:01 jrconway3

long_center_part is here: https://opengameart.org/content/lpc-hair

In the credits:

| long_center_part         | thecilekli, bluecarrot16                                        | CC0                              | touchup                           | https://opengameart.org/content/lpc-long-straight-hair-with-12-colors

Not sure why the credit is missing in credits.csv. Maybe it was a screwup on my part and I accidentally deleted it.

I'll check the history for waistband and see if I can come up for anything as to why that's missing and who added it.

jrconway3 avatar Jan 03 '25 03:01 jrconway3

The weird thing though is that long_center_part doesn't appear to match that entry. However, it did appear that the head/bangs portion was similar, so perhaps the rest of the hairstyle is Bluecarrot's addition to clean it up a bit. Either way, though, those are the correct credits.

jrconway3 avatar Jan 03 '25 03:01 jrconway3

Waistband is Sara. So it should have the same credits as Sara Tunic. I think Bluecarrot simply split this off of the tunic.

jrconway3 avatar Jan 03 '25 04:01 jrconway3

New credits:

hair/long_center_part,,"thecilekli, bluecarrot16",CC0,https://opengameart.org/content/lpc-long-straight-hair-with-12-colors,https://opengameart.org/content/lpc-hair,,,,,,,,,,,,,,OK
torso/waist/waistband,"LPC Sara by Redshrike, contributed by William Thompsonj, Waistband Separated by Bluecarrot16","Bluecarrot16, Mandi Paugh, Stephen Challener (Redshrike), William.Thompsonj",OGA-BY 3.0,http://opengameart.org/content/sara-wizard,https://opengameart.org/content/lpc-sara,,,,,,,,,,,,,,OK

jrconway3 avatar Jan 03 '25 05:01 jrconway3

Here's the comparison: https://github.com/sanderfrenken/Universal-LPC-Spritesheet-Character-Generator/compare/license-handling...jrconway3:Universal-LPC-Spritesheet-Character-Generator:license-handling-issue-142-fixes?expand=1

jrconway3 avatar Jan 03 '25 05:01 jrconway3

New issue to replace this one: https://github.com/LiberatedPixelCup/Universal-LPC-Spritesheet-Character-Generator/issues/39

jrconway3 avatar Jan 03 '25 18:01 jrconway3