Sandeep Mistry

Results 293 comments of Sandeep Mistry

Hey @vshymanskyy, ESP32 should be pretty straightforward to add, the library already has a `BLEDevice` abstraction layer that separates nRF8001 and nRF51/52 support, so it's just a matter of creating...

Hey @floe, Thanks for taking the time to submit this PR! For compatibility reasons, I'd prefer to keep this library peripheral only. However, moving forward it would be great to...

> P.S. The alternative would be to create a dedicated fork of your library that only supports the nRF5x series. Would probably be less work than rebuilding everything to fit...

> My suggestion would be to review this under the assumption that we'll get rid of the nRF8001 support sooner or later. No plans to remove it at this time...

New branch sounds ok short term for development. However, to make it compatible with the Arduino IDE's library manager a new repo would need to be created.

> if I rename my fork to, let's say, BLEPeripheralObserver, would that work? @floe works for me

What values were you using for `PIN_REQ` and `PIN_RST`? Where they past into the `BLEHIDPeripheral` constructor as well? Any way this can be fixed in the lib itself?

> The reason I am asking this stuff is, the ANCS Example runs and I see the Device using my iphone, but when the iphone Messagebox wether I want to...

Hi @gtalusan, what's the specific conflict?

Ok, do you have the output from a compile? Since this library has already in the library manager for a few years, I suggest you ask them to rename to...