arduino-LoRa icon indicating copy to clipboard operation
arduino-LoRa copied to clipboard

Updated interrupt based blocking callback to loop based non-blocking one

Open sheikhmishar opened this issue 3 years ago • 1 comments

As I noticed from the source code, the onTxDone and onReceive callback is executed in an ISR. According to Arduino and ESP documentation, ISR should run nothing more than simple variable manipulation. Also, delay will not work. I have updated the code to sort out these limitations. Please accept this pull request if you think this could be helpful in time critical application

sheikhmishar avatar Dec 19 '22 12:12 sheikhmishar

This seems like a great addition! I've been using the anonymous function idea used here too and the issue is mentioned here too: https://github.com/sandeepmistry/arduino-LoRa/issues/127 would it help this to get merged if instead of being implemented in the examples, the anonymous function were added as a default argument to the Lora.onReceive() function?

geoffreyliddell avatar Sep 02 '24 16:09 geoffreyliddell