arduino-LoRa icon indicating copy to clipboard operation
arduino-LoRa copied to clipboard

Examples: replaced hardcoded value

Open Chornomorets opened this issue 5 years ago • 1 comments

  • replaced hardcoded value with existed variable that contains same value;

Chornomorets avatar Apr 12 '20 17:04 Chornomorets

The reason why it was Hardcoded is that it is a check to see if it was a Broadcast message (0xFF). If you changed the destination to another address (other than broadcast) then the change breaks it the code.

It would be better to add:

#define BROADCAST_ADDRESS 0xFF and use that in the code instead of destination.

dhorner avatar Jul 02 '20 21:07 dhorner