MimeTypeMap
MimeTypeMap copied to clipboard
fixed #110 - some mimetypes were missing x- prefix
Fixed x- prefix for application/x-java-archive, audio/x-aiff, audio/x-m4b, audio/x-scpls, audio/x-wav and image/x-pict
I don't know why it does not recognize the changes correctly but marks the whole file as changed, sorry for that... maybe formatting?
Is there something wrong with the pull request?
Thank you for the contribution. There are two problems and I haven't had time to go through it completely to review completely.
The PR reformats the file completely so the diff looks like every line changed. If I ignore whitespace I can see what actually changed, but if I merge it as is, it'll completely break the line-by-line history. Can you revert whitespace changes and any lines that were not actually meant to change?
Secondly I just checked two of the changes and the first two I checked I found references for that do not use the x- prefix. jar and pict both have references to the mime types without the x- prefix. I recognize this may not be officially correct, but as long as there are some listings showing these are the right mime types, I don't want to break backward compatibility.
Thanks for your contribution. I hope you understand my perspective.
Best,
Sam
Thank you for your feedback...
Yeah sure I understand, I'm an open source developer, too. I'll try to fix the things you mentioned as good as possible ;) May take some days...
Best.
Thank you for your understanding. I look forward to the update whenever you have time.