Sam Goto

Results 159 comments of Sam Goto

Just trying to capture this comment here in the PR, so that it doesn't fall through the cracks: https://github.com/WICG/digital-credentials/pull/57#discussion_r1475960132 So, something that i think is a bit inconsistent with the...

Taking notes here: - we'll use the default implementations of [[[Create]]](https://w3c.github.io/webappsec-credential-management/#algorithm-create-cred) and [[[Store]]](https://w3c.github.io/webappsec-credential-management/#algorithm-store-cred), which returns `null` and throws`NotSupportedError` respectively. - we need to define [[[type]]](https://w3c.github.io/webappsec-credential-management/#dom-credential-type-slot) to return `digital` - we...

> Is it preferable to make FedCM and DigitalCredential, both Credentials in the navigator.identity registry, to enable parsing their config options? I was thinking that if, and ever, we expose...

I think [DigitalCredentialRequestOptions](https://wicg.github.io/digital-credentials/#the-digitalcredentialrequestoptions-dictionary) is correct in that it is the guidance from the credential management spec and consistent with all of the other credential types: - [FederatedCredentialRequestOptions](https://www.w3.org/TR/credential-management-1/#dictdef-federatedcredentialrequestoptions), - [PublicKeyCredentialRequestOptions](https://www.w3.org/TR/webauthn-2/#dictdef-publickeycredentialrequestoptions), -...

> Thinking more about this, I am not sure it makes sense to create a registry at all. The other thing that I think is worth considering is that the...

> why do we need this if OID4VP supports mdocs? I think the intention here was to figure out how to present mdocs while we are working with the OID4VP...

@Sakurann lee kicked this off to get the ball rolling. Does this help? https://github.com/openid/OpenID4VP/issues/90

> I'm wondering if we can declare this out of scope for "v1" Yeah, I think it is reasonable to leave it out of scope for "v1", but I do...

> Add a getIdentity method to CredentialsContainer which is strictly limited to getting IdentityCredentials, but otherwise is the same as get (can probably share almost all the same spec text,...

> but I think I'll take a pass at writing down the alternative proposals on their own so that we can compare and contrast, given how much this has come...