Samuel Colvin

Errors cloning repo and running tests

11

I'm attempting to clone a repo and run tests with a `strider.json` config file and getting numerous errors. After adding the project via github I go to the build page...

Stop auto-importing `panic`, I don't want `core::panicking::panic`

2

## Environment * **IntelliJ Rust plugin version:** `0.4.175.4772-222` * **Rust toolchain version:** `rustc 1.64.0-nightly (d68e7ebc3 2022-07-20)` * **IDE name and version:** PyCharm Professional Build #PY-222.3345.131, built on July 27, 2022...

I agree with @graingert in #164 that we should raise a resource warning just to be safe if `RustNotify` isn't explicitly "closed" even though it mostly wouldn't actually be necessary...

Support `compare_contents`

4

See [here](https://github.com/notify-rs/notify/blob/480de9dc8f227fc9c7d6561837ad38583efe09d3/src/poll.rs#L56-L62), might be good to give this option in a future release, I'm sure someone will want it. ```rs /// Optional feature that will evaluate the contents of changed...

Support `Py_EnterRecursiveCall` and `Py_LeaveRecursiveCall`?

3

I'm struggling with some recursive code in pydantic-core, particularly related to wasm and pyodide, see https://github.com/samuelcolvin/pydantic-core/pull/167. It was suggested I use `Py_EnterRecursiveCall`, is there any case where this would help?...

Support `__del__`

2

I'd like to be able to use a `__del__` method in `#[pymethods]`, however it's not being called. There are two other related issue #402 and #774. #774 seems most relevant...

Add performance suggestions to docs

9

Hi, thanks so much for pyo3 - it's wonderful, I'm using it a lot (see [rtoml](https://github.com/samuelcolvin/rtoml) and [watchfiles](https://github.com/samuelcolvin/watchfiles), I might be using it pydantic soon too). I wonder if it...

`from_py_with` doesn't seem to play nicely with optional arguments

4

### Bug Description When trying to build optional arguments, using `from_py_with` I'm getting ``` expected struct `InnerType`, found enum `Option` ``` ### Steps to Reproduce ```rs fn build_regex(obj: &PyAny) ->...

RangeError: Maximum call stack size exceeded

11

## 🐛 Bug Trying to run pydantic-core's tests on wasm with node locally, and I'm getting the following crash, tests are working ok on github CI. My local machine is...

wrong line numbers when using "flatten"

8

When using `#[serde(flatten)]` the line numbers of errors are wrong. In the scenario below I'm always getting line 2, I guess because this is the first line of the map...