Samuel Colvin
Samuel Colvin
Thanks @BurntSushi, > That said, memchr doesn't do case insensitive search. [Here](https://github.com/apache/arrow-rs/blob/af40ea382275dba967bfabc1632fded07d2129b9/arrow-string/src/predicate.rs#L64-L78) arrow-rs already falls back to using `regex::Regex`, the idea for `quick-strings` is for the very common cases where...
cc @alamb who I think might be interested in this discussion.
See https://github.com/apache/arrow-rs/pull/6118, https://github.com/apache/arrow-rs/pull/6128 and https://github.com/apache/arrow-rs/pull/6131 for implementation in arrow-rs.
Thanks so much for contributing, but I don't really see why this needs to be in core?
In general this looks great. I'm going to try to use it on datafusion-functions-json and let you know how I get on. Should be able to get this done today,...
I'm a bit surprised this got merged without waiting for me to try it on `datafusion-functions-json`! I said just above that I would try to do that yesterday or today....
See the changes coming in #7542, probably best to wait for that to land.
This would be solved by #142. @dmontagu this is an argument to keep the `ctx.end_run(result)` idea.
If you want to simply end the with specific data type, just use `result_type,` you can change the name of that tool with `result_tool_name`, e.g.: ```py from pydantic import BaseModel...
Should be solved by #142, which we should work on again.