arq icon indicating copy to clipboard operation
arq copied to clipboard

chore: Update redis-py<7 & python >= 3.9

Open nsteinmetz opened this issue 6 months ago • 5 comments

  • redis-py 6.x was released
    • redis-py 6.x covers all current supported version of redis and had some breaking changes - so 6.x is the new minimal requirement.
    • Removed the _disconnect_case related test as it no longer exists in redis-py
  • python 3.8 is EOL
  • Added python 3.13
  • Bump dependencies versions

nsteinmetz avatar May 15 '25 08:05 nsteinmetz

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
arq/connections.py 87.50% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   96.27%   96.02%   -0.25%     
==========================================
  Files          11       11              
  Lines        1074     1082       +8     
  Branches      209      144      -65     
==========================================
+ Hits         1034     1039       +5     
- Misses         19       21       +2     
- Partials       21       22       +1     
Files with missing lines Coverage Δ
arq/jobs.py 98.15% <100.00%> (ø)
arq/logs.py 100.00% <100.00%> (ø)
arq/typing.py 100.00% <100.00%> (+9.52%) :arrow_up:
arq/utils.py 100.00% <100.00%> (ø)
arq/version.py 100.00% <100.00%> (ø)
arq/worker.py 97.17% <100.00%> (+<0.01%) :arrow_up:
arq/connections.py 87.50% <87.50%> (-2.57%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a911f3...3ad4b19. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 15 '25 08:05 codecov-commenter

@samuelcolvin what is the strategy / best way to upgrade versions of components ? Such as ruff or pydantic-core ?

Fixed ✅

nsteinmetz avatar May 15 '25 10:05 nsteinmetz

I don't know how to fix this one:

❯ make mypy             
mypy arq
arq/connections.py:104: error: Missing type parameters for generic type "ConnectionPool"  [type-arg]
arq/connections.py:244: error: Argument "sentinels" to "Sentinel" has incompatible type "str | list[tuple[str, int]]"; expected "Iterable[tuple[str, int]]"  [arg-type]
arq/connections.py:249: error: Redundant cast to "ArqRedis"  [redundant-cast]
arq/worker.py:873: error: "ArqRedis" has no attribute "aclose"  [attr-defined]
arq/worker.py:914: error: "ArqRedis" has no attribute "aclose"  [attr-defined]
Found 5 errors in 2 files (checked 12 source files)

Fixed ✅

nsteinmetz avatar May 15 '25 10:05 nsteinmetz

@samuelcolvin : please review the changes, I'm not sure about all of them.

Due to all changes, it may be worth bumping to 0.27 ?

nsteinmetz avatar May 16 '25 07:05 nsteinmetz

@JonasKs @samuelcolvin after reading #437 - is this PR worth ?

nsteinmetz avatar May 22 '25 10:05 nsteinmetz

@JonasKs @samuelcolvin my previous comment is one month old - could you please comment and provide feedback so that we can know what we can expect on arq side ?

nsteinmetz avatar Jun 23 '25 13:06 nsteinmetz

Can somebody take a look at this???

skoolboar avatar Jul 12 '25 15:07 skoolboar

Looks like the project is no longer maintained

lukoshkin avatar Aug 19 '25 10:08 lukoshkin