Support `ACL` flag
I also changed the name of BaseConfigProtocol to ConfigProtocol
Codecov Report
Merging #40 (89f120c) into main (332855f) will decrease coverage by
0.60%. The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 96.64% 96.03% -0.61%
==========================================
Files 10 10
Lines 626 631 +5
Branches 102 103 +1
==========================================
+ Hits 605 606 +1
- Misses 15 17 +2
- Partials 6 8 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| aioaws/_types.py | 100.00% <100.00%> (ø) |
|
| aioaws/_utils.py | 88.88% <100.00%> (ø) |
|
| aioaws/core.py | 98.34% <100.00%> (-1.66%) |
:arrow_down: |
| aioaws/s3.py | 97.69% <100.00%> (-1.51%) |
:arrow_down: |
| aioaws/ses.py | 95.73% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 332855f...89f120c. Read the comment docs.
Will add some thanks for sure.
Do you mean set the acl to None and only use it in case if set? Okay, no problem
Do you mean set the
acltoNoneand only use it in case if set? Okay, no problem
Exactly
Will do, thanks so much for the feedback
This PR it's ready for review, I've been using my fork and the ACL flag it's working correctly. Thanks for this small library