go-thrift icon indicating copy to clipboard operation
go-thrift copied to clipboard

Published 20 hours ago • verified publisher icon samuel

Support more than 64 fields in a struct

Open samuel opened this issue 10 years ago • 3 comments
trafficstars

Currently a uint64 is used to track required fields. This limits a struct to fields with ID < 64. Ideally this limit should be removed.

samuel avatar Sep 25 '15 18:09 samuel

Is this still an issue?

alecthomas avatar Apr 07 '16 05:04 alecthomas

Unfortunately so: https://github.com/samuel/go-thrift/blob/master/thrift/thrift.go#L204

samuel avatar Apr 07 '16 19:04 samuel

@alecthomas thanks for your PR, for now, will use your branch. @samuel could we please merge it? Sounds like a reasonable change.

lc0 avatar Sep 02 '16 09:09 lc0