Adrian Sampson
Adrian Sampson
Good question, @JOJ0!
Cool; thanks for moving this along! It looks like there are a couple of suggestions from the style checker tool. Also, it occurs to me after thinking about the code...
I think the main thing is that, when we eventually called `shlex.split` on the newly-interpolated command, we will want the filename to be preserved as a single shell token. It's...
Consider the case where the config is: ```yaml play: command: mpv $playlist ``` So the `_command_str` function returns the string `"mpv $playlist"`. Eventually, we will call `shlex.split` on this string...
Thanks! Since it seems like somewhere where things could easily go wrong, maybe it would be instructive to have a few tests to show that this is working correctly in...
Wow; thank you for pointing this out! This looks very serious. For a little more background on the issue, the SQLite docs discuss the syntax compatibility problem: https://www.sqlite.org/quirks.html#double_quoted_string_literals_are_accepted Unfortunately, it...
While I am sorry I haven't had the bandwidth to do a thorough review on this, the PR already looks very well thought out. I wouldn't object to merging it....
Yeah, this is a super unpleasant issue to be sure! This kind of re-import is obviously useful, but it's tricky to get right in a way that is uniform w/r/t...
For @scztt-ni: > However, no matter what I specify as the new value for the `singleton` property, beets always reports that it's setting the singleton field to `True` - it...
About the question of what to do for the CLI: one option that might make the most sense, architecturally, would be an alternative to `-L`/`--library`. It could be called `--library-items`,...