Adrian Sampson

Results 1057 comments of Adrian Sampson

Hmm; I'm not entirely sure I understand the root cause: namely, it seems important to know why the original files (the ones being moved) are created with 0600 permissions. It...

Got it; wow; thanks for clarifying!! I did not know this about `mkstemp` and friends. Seems like we clearly need to either: * Do something different from `move`'s current behavior...

That makes sense, although it's a tad unfortunate. There are two things that make that route (leaving the temporary files as they are, and copying them instead of moving): *...

Just checking whether @vicobarberan might be interested in doing another iteration on this PR so we can land it!

That is awesome!!!! Regarding the issue of "related" queries, it seems to me like these run in opposite directions: * `beet list -a title:hello`: Querying albums based on item metadata....

That's interesting! I admit I'm not a user of `badfiles`, so I'm not intimately familiar with the expected behavior here. In a quiet import, it is indeed the case that...

Yes, it does! I've marked this as a bug. When it runs as an import hook, the plugin should probably not print anything and it should definitely not prompt for...

I don't think so—it seems inevitable that this will be on a plugin-by-plugin basis (so they can bring their own notion of what "quietness" means, i.e., what they should do...

Yes, it is indeed inviting bugs to be filed if the plugins don't respect the flag. Unfortunately, I think this is the only way to do it because the plugin's...

Hmm… can you please clarify whether the importer crashes when this happens? Looking at the code, it looks like things are set up to just log the error and move...