Adrian Sampson
Adrian Sampson
Got it! So a good first step, it seems, would be to just handle this `ReadTimeout` error from requests (and presumably retry?).
I would love to keep this overhaul in play.
Yes, let's keep it open.
Absolutely incredible work! Thank you for reviving this effort. I would love to merge this in when we're confident in it! Would you mind doing a little publicity to encourage...
Awesome! I believe the problem is that the CI doesn't trigger when the branch has conflicts. I've resolved the conflict (in the changelog file) and the tests are running now.
One last thing I forgot to mention: it would be great to avoid the duplication in the model classes. At least some of `duplicates` and `construct_match_queries` seem like they could...
Computed (inline) fields are an interesting point! I guess creating a temporary object may be the easiest/lowest-effort way to obtain those, if people want to use them as deduplication keys....
Got it; thanks for clarifying! Computed fields (e.g., from the `inline` plugin) seem like an interesting use case for this. I'm convinced, I think, that creating temporary objects is the...
It's still very much on my to-do list to rearrange some of the low-level query manipulation stuff here… 😕
Thanks for your (extreme) patience while I finally got around to giving this PR the attention it deserved. It was 99% there, but I wanted to simplify the low-level query...