Adrian Sampson

Results 1051 comments of Adrian Sampson
trafficstars

Pull requests to add the necessary files would be greatly appreciated!

Thanks! Maybe I'm being dense here, but I thought because you put `pull_request:` under the `on:` section, this would run the action so we could see what it does on...

Looks good to me! Instead of duplicating the setup code across the two modules, however, what do you think about factoring it out into a common, shared module that both...

Hi—the `import wideq` statements are intentionally embedded in functions instead of being at the module level. This makes it possible to load the component even when the library is not...

Also, it looks like most of the `setup_platform` code is still duplicated across the two modules. It would be really great to move this into a utility module so it...

Sure! I was thinking we could create a new module (i.e., a `.py` file) alongside these where the duplicated code would live. There would be a function or two containing...

You're on the right track, but please put those _after_ the docstrings. I recommend you take a look at the "diff view" here on GitHub: https://github.com/sampsyo/hass-smartthinq/pull/32/files Where you can see...

Hmm; correct me if I'm wrong, but creating _everything_ using the `sensor` component would be undesirable, right? For example, a climate device (thermostat) shouldn't be misclassified as a sensor. It...

> is there an API endpoint that can be polled to return the status/info of all devices? Sadly, no. In fact, you need to "register" for monitoring updates for each...

Yes! I have always wanted to build in a token-grabbing workflow to the HA component—if you want to add that, that would be awesome. And indeed, refactoring would be great...