Adrian Sampson

Results 1046 comments of Adrian Sampson
trafficstars

Cool! I guess it would be nice to keep the name, just in case anyone is depending on that function directly.

I've noticed that GStreamer 1.0 has trouble parsing some MP3 files that other software deals with fine. Can you check whether `gst-play` and `gst-inspect` complain when directed toward the same...

They should coexist peacefully—but `audioread` only uses 1.0 these days. Hmm; maybe I was wrong about `gst-inspect` being the right thing to try. There's some commentary on similar issues on...

Thanks, @jrobeson; I was freehanding and mixed up the GStreamer commands. :cry: Yes, I only saw this for very short files, but the symptom here seems to be the same:...

Got it! Maybe the right behavior here would just be to produce zero for the duration in this case instead of throwing an exception?

Hi! I'm confused by a few things in your example… first: ```py config.set_file("config.yaml") config.set_file("config2.yaml") # Doesn't override items ``` Is this attempting to take the values from `config2.yaml` and "overlay"...

Aha, that's annoying! Any chance you have a test input you could provide so we can craft a fix and a test to make sure we don't reintroduce this?

Thanks!! It turns out that writing tests for this is surprisingly annoying, given the hard-coded way we have of relying on the default source to exclude default options. I gave...

I would be happy to review a PR, but I do not have the bandwidth to implement this myself.