Adrian Sampson
Adrian Sampson
Sure; a wording clarification would be good idea! I'd be happy to accept a pull request that does something like that (as long as it's backwards-compatible).
Hmm; perhaps! But on the other hand, another reasonable (silent) fix might be to round *down* instead of up—that is, to drop the last (partial) sample if it exists. Would...
OK, great! Want to give it a try and see if it works on the file you have?
Hmm; thanks for pointing this out. That flag (`-f s16le`) is intended to dictate the _output_ format from ffmpeg, which is necessary, but you seem to be saying that it's...
It's really valuable to have audioread output a consistent format. If we pass through the underlying sample format, applications will need to add code to deal with, for example, floating-point...
Yep, this is a good idea too. It’s inconsistent because we didn’t previously consider this part of the “public” (cross-backend) interface. But with some thoughtful consideration, we can totally make...
Huh, that's interesting! I don't see an immediate reason why #114 would have caused this, but perhaps @Bomme can see a reason? Can you provide instructions to reproduce the problem?...
Indeed—maybe it would also be worth trying the same code on an older version to check whether the crash is truly new?
This is looking great! I've read a portion so far before needing to head out; I'll be sure to get back to this soon.
This is looking great! We're definitely on the right track. For the next few steps, would you rather work in your fork (I send pull requests there) or create a...