Thomas Gazagnaire

Results 251 comments of Thomas Gazagnaire

@mfeblowitz could you please provide a diagnostic ID so that we can investigate your issue? Thanks! (see https://docs.docker.com/docker-for-mac/troubleshoot/#/diagnose-problems-send-feedback-and-create-github-issues)

Unfortunately I think you hit https://github.com/docker/docker/issues/19647 Usually overlay2 is much more stable than aufs (hence we use it by default in Docker for Mac) but it seems that you have...

Something like `val fold_attrs: ('a -> (string * string) -> 'a) -> 'a -> node -> 'a` ? Ie. fold a function over all the attributes of a node and...

The fix looks ok to me, just two questions: - what's the cost of looking for something in `DLS` for every print operation? (I suspect this is not really an...

@haesbaert do you mind adding a change entry? I'm happy to merge/release this quickly to make a release compatible with multi-domains.

@pedrobslisboa do you mind adding `melange-server-react` to the list of dependencies to please the CI? Thanks!

Thanks! The remaining failures are on unstable distributions: - opensuse-15.5-ocaml-5.1 [universal-portal.0.1 (failed: quickjs.0.1.1 failed to build)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/12bb8f00d4200644524572c2be37ecde3319bcfe/variant/distributions,opensuse-15.5-ocaml-5.1,universal-portal.0.1) - oraclelinux-9-ocaml-5.1 [universal-portal.0.1 (failed: System package install failed with exit code 1 at command:)](https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/12bb8f00d4200644524572c2be37ecde3319bcfe/variant/distributions,oraclelinux-9-ocaml-5.1,universal-portal.0.1)...

I'm closing in favour of #25592 - please help review and test that other (simpler) PR.

What's the relationship with https://github.com/CraigFe/ocamlformat-vmux ?

The change looks fine to me but /cc @art-w and @MisterDA who worked on this piece the most recently.