Samuel Baptista
Samuel Baptista
When you click on a thumbnail, the image opens in photoswipe/lightroom with original size. And then you can zoom on the original sized image. Do you pinch zoom after clicking...
It's not supported and probably conflicting with browser behavior. Pinch in a page will zoom the page itself, not trigger an even on a specific image. Do you have any...
Ok I get the point. I'll think about it and evaluate the technical implications. But there probably wont be an upgrade soon, it may take some time.
Hello thanks for your contribution, I'll review it soon.
I can't run `yarn dev` , it crashes when launch dev : tsup --watch. The issue seems to come from picomatch. Your versions update include many versions of that lib...
> yarn works for running everything locally for me. picomatch still blows up even with the original dependencies What yarn command exactly runs correctly ? Here `yarn dev` fails with...
tsup 8.3 introduces dependance on tinyglobby that seems to deal poorly with picomatch 4. Downgrading to 8.2.4 seems to be fixing the issue. Can you please try on your side....
Appart from the `yarn dev` there is definitely something else broken and the test fail as expected. On my side Natural and Masonry e2e fail. On the masonry case, here...
Great thanks ! I'll probably have a deeper look this week-end
Unfortunately, after an additional small review, I easily found additional broken features. See the last 4 images here : https://ecodev.github.io/natural-gallery-js/docs-api.html. The rendering of the select is different, the button disappeared...