storm-dynamic-spout icon indicating copy to clipboard operation
storm-dynamic-spout copied to clipboard

[SIDELINE] Cleanup PersistenceAdapter.persistSidelineRequestState()

Open stanlemon opened this issue 7 years ago • 0 comments

  • The 'id' is included in the 'request' already, this is an artifact from the past - we should remove it outright.
  • The 'type' could be moved into the 'request', which probably makes more sense anyhow.
  • ConsumerPartition + offsets could be grouped together in a single ConsumerState object, this would move blowing up and persisting by partition into the persistence adapter, but should not functionally change anything. It'll cleanup the logic in the handler quite a bit too, and probably makes more sense in the adapter anyhow since the reason we do it the way we do is very specific for Zookeeper.

stanlemon avatar Nov 22 '17 21:11 stanlemon