akita icon indicating copy to clipboard operation
akita copied to clipboard

Build: cleanup dependencies and add yarn workspaces

Open matheo opened this issue 4 years ago • 2 comments

PR Checklist

  • [x] The commit message follows our guidelines: https://github.com/datorama/akita/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?}

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

The repo has some inconsistent versions of packages, and some redundant ones

What is the new behavior?

I've cleaned up the repeated and unnecessary versions, and updated most packages to the latest available

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

The last commit also adds yarn workspaces to avoid issues in the package's dependencies, as the main package.json was compiling akita with "schematics-utilities": "2.0.2" but it was being published with "^1.1.1"

matheo avatar Mar 09 '21 00:03 matheo

I will redo this PR without the dependencies updates I found that @angular/compiler-cli ngcc introduced the mandatory compileUndecoratedClassesWithAngularFeatures from v10, and it means that for some reason, "ng-packagr": "^9.1.0" is not using the "@angular/compiler-cli": "11.0.5" defined in the package.json, so it's better to leave that bomb quiet :man_shrugging:

matheo avatar Mar 10 '21 01:03 matheo

I just realized that normal build doesn't work, but build --prod does, because Ivy is disabled Maybe the non-working npm scripts could be removed and leave only the working ones.

matheo avatar Mar 10 '21 02:03 matheo