design-system icon indicating copy to clipboard operation
design-system copied to clipboard

fix(rtl): change ltr text-align to rtl-compatible form

Open maxpowa opened this issue 1 year ago • 3 comments

Changes proposed in this pull request:

  • Change a text-align: left to text-align: start to increase RTL compatibility.

Acceptance Criteria

General

  • [x] Tested on desktop (see supported browsers)
  • [x] Tested on mobile (for responsive or mobile-specific features)
  • [x] Confirm Accessibility
  • [x] Confirm RTL (how did this work before this change???)

maxpowa avatar Nov 14 '23 16:11 maxpowa

Thanks for the contribution! Before we can merge this, we need @maxpowa to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Nov 14 '23 16:11 salesforce-cla[bot]

Not sure whats up with the @salesforce-cla bot, I've signed the CLA and it hasn't updated...

Edit: Oopsie, used the wrong author email :sob:

maxpowa avatar Nov 14 '23 17:11 maxpowa

Hi @maxpowa Thank you for your contribution! With these changes affect the CSS, please allow us some time to internally run visual regression testing. I've created an internal ticket to shepherd this through our workflow.

Dottenpixel avatar Jul 23 '24 23:07 Dottenpixel