sagudev
sagudev
Changes to offthread compilation are big (it was removed): https://bugzilla.mozilla.org/show_bug.cgi?id=1845638 https://bugzilla.mozilla.org/show_bug.cgi?id=1846392 https://bugzilla.mozilla.org/show_bug.cgi?id=1846194 https://bugzilla.mozilla.org/show_bug.cgi?id=1809861 now it's done using JS::FrontendContext APIs and tasks controller: https://hg.mozilla.org/mozilla-central/rev/29a877cbf7a9
> This will be problematic: https://bugzilla.mozilla.org/show_bug.cgi?id=1824671 as it requires usage of cbindgen ... > > EDIT: There is `USE_RUST_UNICODE_BIDI`, so we can replace this eventually (in this ESR cycle). Or...
So, the problem is that we need to use our cargo.toml to build icu stuff, but mozilla is patching them in tree, and we cannot do that (every consumer would...
> `NewExternalArrayBuffer` has been changed to take a `UniquePtr`, so a wrapper needs to be added. https://searchfox.org/mozilla-esr128/source/js/src/vm/ArrayBufferObject.cpp#3085 Thanks for heads up, currently I only done changes to make it work...
Ideally one day we would get more high level wrapper: here is it for uniffi in mozilla tree https://searchfox.org/mozilla-central/source/toolkit/components/uniffi-js/OwnedRustBuffer.cpp#88
Currently it is preferred to use mozjs via git, pinning a specific commit, like so: `mozjs = { git = "https://github.com/servo/mozjs" }`.
This is done now, for next ESR there is https://github.com/servo/mozjs/issues/476
I think the best way would be to simply update servo's rust version. There is already PR for that: https://github.com/servo/servo/pull/29993
Could this be problematic? https://github.com/servo/mozjs/blob/7184f658b7e2de8a8d288ff39001364513115782/mozjs-sys/makefile.cargo#L12
Would it be possible to also add test for `Range`?