pycares
pycares copied to clipboard
saghul
Add 3.13 support, remove 3.8
CI will fail on 3.13 builds until https://github.com/actions/python-versions/pull/312 is merged to add 3.13 support to setup-python
https://github.com/actions/python-versions/pull/312 has been merged, and 3.13 CI has passed here. Unsure why the macOS runners aren't picking up the outstanding jobs though.
@saghul this is ready for review :)
macOS CI failed as no runner picked up the jobs within a day, rather than due to an error in the change itself.
That doesn't mean there isn't a problem with these changes, just that we don't know yet.
macOS 11 was decomissioned, so we need to update https://github.com/saghul/pycares/blob/57a82a0039ad2607092abe6aff0f06be17a400f2/.github/workflows/test.yml#L12
Updated CI to run using macOS 13 (newest x86) and macOS 15 for M1 support.
Various mac versions are failing the test_custom_resolvconf test due to the errorno not being the expected value. Unsure on the cause of this, as some version of Python finish tests just fine, and the ones that fail aren't consistent across macOS 13 & 15.
Can we get this merged and released?
I'm really looking forward to Python 3.13 support :)
Thank you!
Yeah, it looks like it's a potential flaky test, as it works on some Python versions on macOS 13 and then other Python versions on macOS 15.
I don't have a mac so can't reproduce in order to fix it.
It doesn't look like the failing tests are related to the Python 3.13 upgrade.
I've been looking into the tests and my best guess is that it has to do with something with MacOS or how the tests are set up
hey @saghul is there anything blocking making a release to pypi for this PR that we can help with?
I tried to publish them but ran into a problem. Looks like a v3 / v4 upload action shenanigans.
I'll try to look into it soon.
Hey, @saghul. I've created a PR which should fix the CI release and also added more platforms to cibuildwheel. See https://github.com/saghul/pycares/pull/204.