safe-wallet-web
safe-wallet-web copied to clipboard
feat: allow users to hide Safe Pass promotion
How this PR fixes it
Adds "Don't show again" button to Safe Pass promotion.
How to test it
- Go to the dashboard on a mainnet Safe
- Hide the promotion
Screenshots
Checklist
- [x] I've tested the branch on mobile π±
- [x] I've documented how it affects the analytics (if at all) π
- [x] I've written a unit/e2e test for it (if applicable) π§βπ»
Branch preview
β Deploy successful!
Website: https://feat_hide_pass_promo--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6
Storybook: https://feat_hide_pass_promo--walletweb.review.5afe.dev/storybook/
ESLint Summary View Full Report
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
- Result: :white_check_mark: success
- Annotations: 0 total
Report generated by eslint-plus-action
π¦ Next.js Bundle Analysis for safe-wallet-web
This analysis was generated by the Next.js Bundle Analysis action. π€
β οΈ Global Bundle Size Increased
| Page | Size (compressed) |
|---|---|
global |
950.48Β KB (π‘ +37Β B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/home |
58.46Β KB (π‘ +71Β B) |
1008.94Β KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 78.48% (-0.02% π») |
11727/14943 |
| π΄ | Branches | 58.82% (-0.02% π») |
2958/5029 |
| π‘ | Functions | 65.96% (-0.04% π») |
1878/2847 |
| π‘ | Lines | 79.85% (-0.02% π») |
10570/13237 |
Show files with reduced coverage π»
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π΄ | ... / sentry.ts |
46.67% (-20% π») |
0% (-11.11% π») |
0% (-100% π») |
46.15% (-23.08% π») |
Test suite run success
1450 tests passing in 201 suites.
Report generated by π§ͺjest coverage report action from aea98afc37b50b1db50f60089cd226742b5e066a
@schmanu It seems the PR didn't actually deployed. The environment doesn't work, throws a 404. Maybe it has to do with what it was discussed here ?
@francovenica I merged dev into this and it works again. Can you re-test?
Thanks for re-building.
The button works fine, but it looks kinda out of place for the mobile viewport for being next to the "load more".
I'd say that it should look like this, where if you reduce the view port even more the "load more" goes down a bit. but the button probably should be centered if this is the case:
@TanyaEfremova Any suggestion?
Fair comment! Is it possible to implement the following rules to the mobile button groups in widgets:
- Display them 1 below another and stretch in full width
- Learn more can belong to the stepper component and be shown below
cc @schmanu
@francovenica I adjusted it according to Tanyas comments. Can you re-check?
ESLint Summary View Full Report
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
- Result: :white_check_mark: success
- Annotations: 0 total
Report generated by eslint-plus-action
Looks nice!
ESLint Summary View Full Report
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
- Result: :white_check_mark: success
- Annotations: 0 total
Report generated by eslint-plus-action