socketcluster-client-java icon indicating copy to clipboard operation
socketcluster-client-java copied to clipboard

Subscribe

Open nakul91 opened this issue 8 years ago • 14 comments

Need to pass the arguments to subscribe as an issue of security.

nakul91 avatar Sep 28 '17 07:09 nakul91

Can you describe your problem in detail?

sacOO7 avatar Sep 28 '17 17:09 sacOO7

Hey Sachin,

In the javascript client I can do the following when subscribing to a channel. channel = socket.subscribe(${userid}, { data : {userid : ${userid}, token : 'eyJhbGciOiJSUzI1NiIsInR5cCI6Ikp'} });

So we want to know if a similar thing can be done in the Android client as well. We use the user id and token to authenticate the subscribe request.

Regards, Joyson.

joysonvd avatar Oct 23 '17 10:10 joysonvd

any update on the above issue.

nakul91 avatar Jan 24 '18 15:01 nakul91

Hi @nakul91 can you describe your problem in more detail?

sacOO7 avatar Jan 24 '18 19:01 sacOO7

Hi @sacOO7 right now we cannot authenticate the subscribe functionality as its just a call back function as follow: socket.createChannel(" XX ").subscribe(new Ack() { @Override public void call(String name, Object error, Object data) {

        }
    });

in the backend, they have updated the authentication with the token as specified by @joysonvd in the above posts. So how can we update the token while subscribing, in android?

nakul91 avatar Jan 25 '18 05:01 nakul91

I have the same problem, I need to add a jwt token in the data payload. But unfortunately, this is not exposed by the subscribe method. Any update?

kuhnp avatar Mar 16 '18 14:03 kuhnp

@sacOO7 this issue got fixed in ios but not in the android can you pls fix this up.

nakul91 avatar Apr 05 '18 06:04 nakul91

@sacOO7 this can help https://github.com/sacOO7/socketcluster-client-swift/pull/5/commits/2a60fac9182ca3f0d3e60996ea96ce1a137b0cd1

nakul91 avatar Apr 05 '18 06:04 nakul91

Yes sure @nakul91 , I will take a look at it....

sacOO7 avatar Apr 05 '18 07:04 sacOO7

@sacOO7 thanks 👍

nakul91 avatar Apr 05 '18 07:04 nakul91

Hi @sacOO7, Have you been able to get through to this.

joysonvd avatar Jun 01 '18 05:06 joysonvd

Will probably work on it today and let you know about it 👍

On Jun 1, 2018 10:40 AM, "joysonvd" [email protected] wrote:

Hi @sacOO7 https://github.com/sacOO7, Have you been able to get through to this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sacOO7/socketcluster-client-java/issues/16#issuecomment-393759552, or mute the thread https://github.com/notifications/unsubscribe-auth/AP8vSXY6WOi9N8dvj66iGW3gHCUcEx94ks5t4MzTgaJpZM4Pm2Jw .

sacOO7 avatar Jun 01 '18 05:06 sacOO7

Hi @sacOO7 any update on this issue

nakul91 avatar Jul 26 '18 07:07 nakul91

Hi @nakul91 , I am currently porting all functionality from js client to java. You can find updated here. Since I am working on Unity client, this will take some time to complete. https://github.com/sacOO7/socketcluster-client-java/tree/feature/syncJsClient.

sacOO7 avatar Jul 26 '18 08:07 sacOO7